Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add all syncpack cosmiconfig config #2282

Merged
merged 2 commits into from Apr 20, 2024
Merged

Conversation

Airkro
Copy link
Contributor

@Airkro Airkro commented Apr 19, 2024

@JamieMason
Copy link

Thanks for this @Airkro.

It looks like according to the "myapp" example in the cosmiconfig readme that all the possible filenames and paths are as follows:

.config/syncpackrc
.config/syncpackrc.cjs
.config/syncpackrc.js
.config/syncpackrc.json
.config/syncpackrc.mjs
.config/syncpackrc.ts
.config/syncpackrc.yaml
.config/syncpackrc.yml
.syncpackrc
.syncpackrc.cjs
.syncpackrc.js
.syncpackrc.json
.syncpackrc.mjs
.syncpackrc.ts
.syncpackrc.yaml
.syncpackrc.yml
syncpack.config.cjs
syncpack.config.js
syncpack.config.mjs
syncpack.config.ts

@Airkro Airkro changed the title fix: syncpack icon config feat: add all syncpack cosmiconfig config Apr 19, 2024
@Airkro
Copy link
Contributor Author

Airkro commented Apr 19, 2024

@JamieMason Done.

@PKief PKief merged commit d9a6a2d into PKief:main Apr 20, 2024
2 checks passed
Copy link

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the marketplace.

@Airkro Airkro deleted the fix-syncpack-config branch April 20, 2024 12:55
@Airkro
Copy link
Contributor Author

Airkro commented Apr 20, 2024

@PKief

Many popular tools, like eslint/stylelint/prettier/syncpack/postcss/babel/graphql/commitlint... use config loaders like cosmiconfig/lilconfig/unoconfig/rc-loader...

They all have a long filename list like this, For now, many of them are still not completing the list.

Currently, people help maintain these filenames by creating similar patterns and checking them line by line to identify which ones are missing. This process results in numerous pull requests.

Do you agree to create some helper functions as built-in support? It will make the list shorter, and easy to maintain, and easy to send PR in the future.

I love to send a PR, like this:

image

@PKief
Copy link
Owner

PKief commented Apr 20, 2024

@Airkro thanks for the suggestion. Yeah that sounds like a nice idea. We should ensure that adding of file names should be still possible if some frameworks require additional file names or file extensions. Feel free to work on this and provide a PR for it, I'd appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants