Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Quokka icon and file-extension default config #2152

Merged
merged 6 commits into from Apr 9, 2024

Conversation

lunelson
Copy link
Contributor

This PR copies the Wallaby.js icon and changes its color to the Quokka.js brand color; it also adds a config to show the Quokka icon for any files named with *.quokka.{tsx?,jsx?}

Signed-off-by: Lu Nelson <lunelson@gmail.com>
Signed-off-by: Lu Nelson <lunelson@gmail.com>
Copy link

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@tj-commits
Copy link
Contributor

I like that

@PKief PKief self-requested a review March 5, 2024 20:51
Repository owner deleted a comment from github-actions bot Mar 5, 2024
Copy link

github-actions bot commented Mar 5, 2024

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

Repository owner deleted a comment from github-actions bot Mar 17, 2024
@lunelson
Copy link
Contributor Author

lunelson commented Apr 7, 2024

Thanks @tj-commits and @PKief, for taking a look at this. What do you think? Are you in to merging it?

Copy link

github-actions bot commented Apr 9, 2024

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@PKief PKief merged commit 4ab6fd6 into PKief:main Apr 9, 2024
4 checks passed
Copy link

github-actions bot commented Apr 9, 2024

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the marketplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants