Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add "Change File Color" functionality #1916

Merged
merged 5 commits into from Apr 5, 2023

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Mar 27, 2023

Fixes #1344, but in a much more modular format

  • Acts identically to changing the folder color, but applies to the default file icon instead
  • Remove & ignore "file.svg", as it's now autobuilt
  • Use grey as default color instead of blue, as that was commonly recommended and changing back to blue would now be painless

As far as the logic is concerned, this is fully-functional as-is. It'll still need translations for languages besides English for the nls files, but that's beyond my ability

• Acts identically to changing the folder color, but applies to the default file icon instead
• Remove & ignore "file.svg", as it's now autobuilt
• Use grey as default color instead of blue, as that was commonly recommended and changing back to blue would now be painless
@PKief PKief self-requested a review March 27, 2023 19:06
Copy link
Owner

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, it looks really good. I will play around with it a bit to check if everything works fine before I'll push an update. Additionally, I've added a few translations for the input dialog.

PKief and others added 3 commits April 5, 2023 21:32
Co-authored-by: Philipp Kief <philipp.kief@gmx.de>
* .rc icon & file extension

* Update c icon colors

---------

Co-authored-by: Philipp Kief <philipp.kief@gmx.de>
@PKief PKief merged commit 4c73696 into PKief:main Apr 5, 2023
2 of 3 checks passed
@Repiteo Repiteo deleted the change-file-color branch April 5, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recolour default file icon
3 participants