Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add icon for folder elixir #1778

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add icon for folder elixir #1778

wants to merge 1 commit into from

Conversation

devdeveloper1
Copy link

No description provided.

@devdeveloper1 devdeveloper1 changed the title add-folder-elixir add folder elixir Nov 27, 2022
@devdeveloper1 devdeveloper1 changed the title add folder elixir add icon for folder elixir Nov 27, 2022
PKief
PKief reviewed Nov 28, 2022
View reviewed changes
Copy link
Owner

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Usually the folder has a darker background color than the icon before. So these proposed icons of this PR would be a bit better.

#1403

So probably we should go with #1403, but I'll need some time to take a look into this.

@devdeveloper1
Copy link
Author

Thanks for the PR. Usually the folder has a darker background color than the icon before. So these proposed icons of this PR would be a bit better.

#1403

So probably we should go with #1403, but I'll need some time to take a look into this.

Hey, honestly i don't mind if you choose my icon or the other icon i just wanted to not to have to see the default folder icon on .elixir_ls folders.
Sorry for taking so long to reply!

@PKief PKief force-pushed the main branch 3 times, most recently from 640fb8a to d5912bb Compare November 18, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PKief PKief PKief left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devdeveloper1 @PKief