Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shield Staking #2836

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Shield Staking #2836

wants to merge 17 commits into from
+1,556 −399

Conversation

panleone
Copy link

@panleone panleone commented Apr 7, 2023 •
edited

This PR will create the Shield Staking system, i.e. the ability to stake using a sapling note. It is more or less split in 5 big parts:

  1. Rewrite the stake system for shield notes (DONE)
  2. Conventionally decide inputs and outputs of a shield stake tx and change consensus rules accordingly (DONE)
  3. Finally prove that a given stake is valid without revealing the amount staked (DONE)
  4. New block signature for shield staking (DONE)
  5. Unit and functional tests (DONE)

I will add more technical details of the system later

@panleone panleone force-pushed the shield_staking branch 2 times, most recently from e5edfa4 to 7277289 Compare April 8, 2023 21:13
@panleone panleone added Block Generation Mining/Staking related issues Sapling Protocol-Update labels Apr 11, 2023
@panleone panleone added this to the 6.0.0 milestone Apr 14, 2023
@panleone panleone marked this pull request as draft April 18, 2023 06:28
@panleone panleone force-pushed the shield_staking branch 6 times, most recently from c0ea05f to 50cb87a Compare April 21, 2023 13:13
@Duddino Duddino force-pushed the shield_staking branch 3 times, most recently from 8034ce6 to 1c94c3e Compare May 2, 2023 11:25
@panleone panleone force-pushed the shield_staking branch 11 times, most recently from bfc3b48 to 2595e4e Compare July 19, 2023 16:53
@Duddino Duddino force-pushed the shield_staking branch 3 times, most recently from b63f9da to be17a69 Compare September 13, 2023 13:56
panleone and others added 7 commits September 13, 2023 16:00
@panleone @Duddino
Add UPGRADE_SHIELD_STAKING to chainparams
5e11f1c 
Co-authored-by: Alessandro Rezzi <alessandrorezzi2000@gmail.com>
@Duddino @panleone
[Kernel] Add CShieldStake
8438227 
Co-authored-by: Alessandro Rezzi <alessandrorezzi2000@gmail.com>
@panleone @Duddino
[Primitives] Update Block and Transaction classes
4713a62 
Upgrade block version to 12;
Add shield proof template
Add shield stake transactions
@Duddino
[Wallet] Add CStakeableInterface
744f548
@Duddino
[Validation] Partial implementation of CheckShieldStake
8213d6b
@panleone @Duddino
[Kernel] Kernel shield stake upgrade
13c4567
@panleone @Duddino
[Miner] Add support to shield staking
37b15d1
@Duddino Duddino force-pushed the shield_staking branch 4 times, most recently from df5b74f to 91f68ad Compare September 13, 2023 16:49
@panleone panleone marked this pull request as ready for review September 13, 2023 18:18
@panleone panleone changed the title [WIP] Shield Staking Shield Staking Sep 13, 2023
@Duddino Duddino force-pushed the shield_staking branch 2 times, most recently from b2e4379 to 8ae9f3f Compare September 14, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@panleone panleone

@Duddino Duddino

Labels
Block Generation Mining/Staking related issues Protocol-Update Sapling
Projects
PIVX Core
Status: In Progress
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@panleone @Duddino