Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactoring] Clean budget manager code redundancies #2752

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[Refactoring] Clean budget manager code redundancies #2752

wants to merge 5 commits into from
+61 −121

Conversation

furszy
Copy link

@furszy furszy commented Feb 22, 2022

Following points tackled:

  1. Cleaned BudgetManager::CheckCollateral code redundancies.
  2. Moved CBudgetManager::GetFinalizedBudgetStatus to the RPC file as it's an utility function.
  3. Remove unused function CBudgetManager::GetFinalizedBudget.

@furszy furszy self-assigned this Feb 22, 2022
@random-zebra random-zebra added this to the 6.0.0 milestone Feb 24, 2022
random-zebra
random-zebra approved these changes Feb 24, 2022
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 42bca64

src/budget/budgetmanager.cpp Show resolved Hide resolved
Fuzzbawls
Fuzzbawls approved these changes Mar 11, 2022
View reviewed changes
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a102664

Liquid369
Liquid369 approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK a102664
Tested changes in PR #2804 this code cleanup would be good to merge with DMN/6.0

panleone
panleone approved these changes Feb 10, 2023
View reviewed changes
Copy link

@panleone panleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK a102664:
Good cleanup, tested the last week in regtest with the full v6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fuzzbawls Fuzzbawls Fuzzbawls approved these changes

@random-zebra random-zebra random-zebra approved these changes

@panleone panleone panleone approved these changes

@Liquid369 Liquid369 Liquid369 approved these changes

Assignees

@furszy furszy

Labels
Refactoring
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@furszy @Fuzzbawls @random-zebra @panleone @Liquid369