Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: StrikeThrough property in word2007 #2604

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

noec764
Copy link

@noec764 noec764 commented Apr 4, 2024

I had a problem with strike through in Word2007.
If a strikethrough style was added to a text element it never appeared in the resulting document.
Indeed, the XML generated was as follows

<w:r>
    <w:rPr>
        <w:strike w:val="1"/>
        <w:dstrike w:val="0"/>
     </w:rPr>
     <w:t xml:space="preserve">some text</w:t>
</w:r>

The statement <w:dstrike w:val="0"/> should not be present here
I figure out that the test $style->isDoubleStrikethrough() !== null is true if $style->isDoubleStrikethrough() === false
So as a text cannot be strike and doublestrike at the same time, word2007 ignores it.

@coveralls
Copy link

Coverage Status

coverage: 97.217%. remained the same
when pulling bde34d3 on noec764:FIX_StrikeThrough_property_Word2007
into 8b891bb on PHPOffice:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants