Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<w:lastRenderedPageBreak/> page break support #2573

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stanolacko
Copy link

Description

Some Word2007 document are using <w:lastRenderedPageBreak/>for page break. When converting this document to PDF, it does not add page break in final PDF.

@coveralls
Copy link

coveralls commented Feb 18, 2024

Coverage Status

coverage: 97.209% (-0.008%) from 97.217%
when pulling b0dc3e3 on stanolacko:w-lastRenderedPageBreak
into 8b891bb on PHPOffice:master.

Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a Line in the Changelog and a unit test ?

src/PhpWord/Reader/Word2007/AbstractPart.php Outdated Show resolved Hide resolved
@stanolacko
Copy link
Author

What kind of test is requered? For example simple text, with <w:lastRenderedPageBreak/> which generated 2 pages document?

Co-authored-by: Progi1984 <progi1984@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants