Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Do Not Install #2567

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

oleibman
Copy link
Contributor

@oleibman oleibman commented Feb 6, 2024

All my unimplemented changes. Not intended for install.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

All my unimplemented changes. Not intended for install.
@oleibman oleibman marked this pull request as draft February 6, 2024 23:25
@coveralls
Copy link

coveralls commented Feb 6, 2024

Coverage Status

coverage: 97.26% (+0.04%) from 97.217%
when pulling 39fbabc on oleibman:wordunimplemented2
into 8b891bb on PHPOffice:master.

Better from a technical standpoint.

Pre-processing much simplified.

Some post-processing added because loadHTML preserveWhiteSpace=false does not work well.

Not-UTF8 html can now be loaded.

No need to surround snippets with body tag.
It's debatable, but allow unescaped ampersand and unknown charset.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants