Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background and border color transparency support for textboxes when color is undefined #2555

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Chudy20007
Copy link

Description

In project we use text boxes for imprints and side notes on a word document. It's currently not possible to use non-white background with border. As a simple fix I implement simple check if border or background color is set - if not then text box should be rendered with a transparent colors, else current behavior will be used.

Fixes # (issue)

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@coveralls
Copy link

Coverage Status

coverage: 97.218% (+0.001%) from 97.217%
when pulling 59ed844 on Chudy20007:transparent-textbox
into 2f4da6e on PHPOffice:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants