This repository has been archived by the owner on Jan 2, 2019. It is now read-only.
Dynamic range #824
Open
Dynamic range #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nlyRange() cannot contain body
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading a spreadsheet with a dynamic range definition (see dynamic defined range) the named ranges are not being added to the workbook. The reason for this that PHPExcel_Worksheet::extractSheetTitle method is not currently setup to handle parsing the OFFSET formula that is used for this.
This small change to the method specifically looks for this string in the formula and strips it out accordingly to return the extracted elements as per a non dynamic range.
It's possible that this is not the ideal solution to this problem, if there are other types of formula that might arise for named ranges. I am by no means an expert in excel, and this change is something I have made for my specific use case. I am happy to help out where possible if this needs further digging though,