New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow use within PHP_CodeSniffer itself #215
base: main
Are you sure you want to change the base?
Conversation
@fredden I'm not sure I see the point of this change ?
What am I missing ? |
Correct. I was working on changing that, as you'd suggested that in the future it would be good to use the PHPCSDevCS standard internally for PHP_CodeSniffer. That change is low priority, and involves a large change to the code-base, so is unlikely to happen in the short term. In order to avoid duplication, I installed PHPCSDevCS via Composer, and found this incompatibility.
Making this change seemed cleaner and more robust than setting a hard-coded |
I understand what you are trying to do, but this is not the time. Let's focus on what's in front of us right now first. It may still be years before that CS change in PHPCS itself happens, it may never happen. If anything, in my mind, it will likely be an iterative process with small changes to normalize the code a bit more over time, bit by bit, until it is at a point that a switch would be realistic. |
Proposed Changes
While looking into changing the coding standard used for PHP_CodeSniffer itself, I noticed that this plug-in doesn't currently work in that scenario. This pull request allows this plug-in to be used within the PHP_CodeSniffer repository.
Related Issues
Related to PHPCSStandards/PHP_CodeSniffer#122 (review)