Add COMPOSER_AUTH env variable to workflows #200
Conversation
Because of the amount of GitHub API calls composer does, the CI runs into a rate limit. This causes jobs to fail or be aborted. By adding the GITHUB_TOKEN as auth method, this can be avoided.
There was a problem hiding this comment.
Reviewed:
- While I'm not sure it will solve all the issues (the most recent ones point to an issue with powershell ?), I totally agree that this should help.
- Do we really need it in all workflows though ? Or only in the
integrationtest.ymlfile ? (which is the only one which has been giving us trouble) - Is setting it via
env: COMPOSER_AUTHthe right way to set this ? Or should we leverage thesetup-phpaction for this ? (which can set the Composer authentication up persistently)
Ref: https://github.com/shivammathur/setup-php#github-composer-authentication
|
Accidentaly pressed the "Request Review" button again. Sorry! |
|
From what I could see, the error in the powershell were triggered by composer, caused by the rate limit:
The fix was proposed in ramsey/composer-install#182 (comment) but sadly this change does not seem to fix the rate limit issue so another approach seems needed. I'll take a look at the setup-php docs. I just added it to all workflows that do a composer install/update just to be safe (as I have no idea how the rate limit between GitHub / Composer / GHA. Leaving this for now. |
Proposed Changes
Because of the amount of GitHub API calls composer does, the CI runs into a rate limit. This causes jobs to fail or be aborted. Adding the GITHUB_TOKEN as auth method should avoid these rate limits.
Related Issues