Skip to content

Commit

Permalink
GH Actions/test: PHP 8.3 has been released
Browse files Browse the repository at this point in the history
* Builds against PHP 8.3 are no longer allowed to fail.
* Add _allowed to fail_ build against PHP 8.4.
  • Loading branch information
jrfnl committed Nov 26, 2023
1 parent eda4086 commit 4837488
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 5 deletions.
13 changes: 10 additions & 3 deletions .github/workflows/integrationtest.yml
Expand Up @@ -35,6 +35,7 @@ jobs:
- '8.1'
- '8.2'
- '8.3'
- '8.4'
composer:
- 'v1'
- 'v2'
Expand Down Expand Up @@ -74,6 +75,9 @@ jobs:
- php: '8.3'
composer: '2.2'
os: 'ubuntu-latest'
- php: '8.4'
composer: '2.2'
os: 'ubuntu-latest'

- php: '7.2'
composer: '2.2'
Expand All @@ -96,6 +100,9 @@ jobs:
- php: '8.3'
composer: '2.2'
os: 'windows-latest'
- php: '8.4'
composer: '2.2'
os: 'windows-latest'

# Also test against the dev version of Composer for early warning about upcoming changes.
- php: 'latest'
Expand All @@ -108,7 +115,7 @@ jobs:

name: "Integration test"

continue-on-error: ${{ matrix.php == '8.3' || matrix.composer == 'snapshot' }}
continue-on-error: ${{ matrix.php == '8.4' || matrix.composer == 'snapshot' }}

steps:
- name: Checkout code
Expand All @@ -132,15 +139,15 @@ jobs:
# Install dependencies and handle caching in one go.
# @link https://github.com/marketplace/actions/install-php-dependencies-with-composer
- name: Install Composer dependencies
if: ${{ matrix.php != '8.3' }}
if: ${{ matrix.php != '8.4' }}
uses: "ramsey/composer-install@v2"
with:
composer-options: '--optimize-autoloader'
# Bust the cache at least once a month - output format: YYYY-MM.
custom-cache-suffix: $(date -u "+%Y-%m")

- name: Install Composer dependencies
if: ${{ matrix.php == '8.3' }}
if: ${{ matrix.php == '8.4' }}
uses: "ramsey/composer-install@v2"
with:
composer-options: '--ignore-platform-reqs --optimize-autoloader'
Expand Down
5 changes: 3 additions & 2 deletions tests/PHPCSVersions.php
Expand Up @@ -354,9 +354,10 @@ function ($version) {
break;

case '8.3':
case '8.4':
/*
* At this point in time, it is unclear as of which PHPCS version PHP 8.2 will be supported.
* In other words: tests should only use dev-master/4.x when on PHP 8.2 for the time being.
* At this point in time, it is unclear as of which PHPCS version PHP 8.3/8.4 will be supported.
* In other words: tests should only use dev-master/4.x when on PHP 8.3/8.4 for the time being.
*/
$versions = array();
break;
Expand Down

0 comments on commit 4837488

Please sign in to comment.