Create validate-namespace.yaml #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmalen
approved these changes
May 15, 2024
ericmalen
approved these changes
May 15, 2024
vedantthapa
reviewed
May 15, 2024
Comment on lines
+67
to
+68
| - name: Install yq | ||
| uses: mikefarah/yq@v4 |
There was a problem hiding this comment.
IIRC, steps are executed sequentially in GH actions, so this would probably go before the Validate namespace step?
However, it's been a while since I've looked at actions so I might be wrong on this 😅
| - name: Validate namespace | ||
| id: validate-namespace | ||
| run: | | ||
| files_with_namespace=() |
There was a problem hiding this comment.
Is this required? I don't a see a reference to this anywhere else in the code.
Edit: Only referring to the files_with_namespace variable here
Comment on lines
+26
to
+44
| changed_files=$(git diff --name-only HEAD^..HEAD) | ||
| echo "Changed Files" | ||
| echo "$changed_files" | ||
|
|
||
| if [ -n "$changed_files" ]; then | ||
| while IFS= read -r file; do | ||
| if [[ "$file" =~ \.y(a)?ml$ ]]; then | ||
| yaml_files+=("$file") | ||
| fi | ||
| done < <(echo "$changed_files") | ||
|
|
||
| echo -e "\nFound yaml files:" | ||
| for file in "${yaml_files[@]}"; do | ||
| echo "$file" | ||
| done | ||
| else | ||
| echo -e "\nNo YAML files were changed." | ||
| exit 0 | ||
| fi |
There was a problem hiding this comment.
Totally being a nitpick here, do you think it'd be helpful to collapse this into a single command -
yaml_files=($(git diff --name-only HEAD^..HEAD | grep -E '\.y(a)?ml$'))The grep -E would filter out .yaml / .yml files.
If this was meant to provide more verbose outputs to the user then please feel free to disregard this suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.