Split version checking from use Alien::Gnuplot
#99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in order to make downstream packaging easier. This works around dependency scanning code that assumes the standard semantics where a version-like string in that location refers to the version of the Perl module that is stored in the package variable `$VERSION`. In particular, this is what `rpmbuild` does via the `perl-generators` plugin per <https://github.com/jplesnik/generators/blob/1.16/template/bin/perl.req#L240>. Fixes <#98>.
Pull Request Test Coverage Report for Build 5894230573
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to make downstream packaging easier.
This works around dependency scanning code that assumes the standard
semantics where a version-like string in that location refers to the
version of the Perl module that is stored in the package variable
$VERSION.In particular, this is what
rpmbuilddoes via theperl-generatorsplugin per https://github.com/jplesnik/generators/blob/1.16/template/bin/perl.req#L240.
Fixes #98.