Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GS: Misc fixes #11229

Merged
merged 3 commits into from May 12, 2024
Merged

GS: Misc fixes #11229

merged 3 commits into from May 12, 2024
+76 −58

Conversation

stenzek
Copy link
Member

@stenzek stenzek commented May 11, 2024

Description of Changes

GS: Fix use-after-free on lost device

  • Stops PCSX2 accessing freed memory on device loss. I mean, we're probably going to flop anyway since it's just going to crash the GPU again, but use-after-frees are bad.

GS/HW: Fix invalid self copy from move in DX renderers

  • Spec violation in DirectX.

GS/HW: Fix possible texture leak on skipped draw

  • Temp targets don't get cleaned up. Also very unlikely, but avoids a goto here.

Rationale behind Changes

Correctness

Suggested Testing Steps

Smoke test because who cares about directx anyway

@stenzek stenzek merged commit 4cc4a65 into PCSX2:master May 12, 2024
12 checks passed
@stenzek stenzek deleted the dx branch May 12, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamfretoz kamfretoz kamfretoz approved these changes

@JordanTheToaster JordanTheToaster JordanTheToaster approved these changes

Assignees
No one assigned
Labels
GS: Hardware GS: Texture Cache GS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stenzek @kamfretoz @JordanTheToaster