GS/Vulkan: Always issue first barrier on RDNA3 #11223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out *not* doing this causes GPU resets on RDNA3, specifically Windows drivers. Despite the layout changing enforcing the execution dependency between previous draws and the first input attachment read, it still wants the region/fragment-local barrier...
stenzek
force-pushed
the
the-barrier-man-giveth-and-the-barrier-man-taketh-away
branch
from
9598969
to
9d3a536
Compare
Completely redundant. We also don't need to use the drawlist.
stenzek
force-pushed
the
the-barrier-man-giveth-and-the-barrier-man-taketh-away
branch
from
9d3a536
to
bbdda4a
Compare
JordanTheToaster
approved these changes
May 10, 2024
kamfretoz
approved these changes
May 11, 2024
stenzek
deleted the
the-barrier-man-giveth-and-the-barrier-man-taketh-away
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
So I bought a 7900GRE to debug this issue and...
It turns out not doing this causes GPU resets on RDNA3, specifically Windows drivers. Despite the layout changing enforcing the execution dependency between previous draws and the first input attachment read, it still wants the region/fragment-local barrier...
Rationale behind Changes
(Hopefully) Fixes the RDNA3 crashes.
Fixes #10720.
Suggested Testing Steps
Smoke test Vulkan renderer.
See if RDNA3 no longer crashes.