Core: Refactor a lot of timer work and fix a couple of bugs #11220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refractionpcsx2
force-pushed
the
core_timerrefactor
branch
from
f616af4
to
caa48d4
Compare
EE/IOP Timers: improve clock sync, disable v/h sync when SINT enabled. Some changes based on tests from PS2 [SAVEVERSION+]
refractionpcsx2
force-pushed
the
core_timerrefactor
branch
from
caa48d4
to
36409eb
Compare
kamfretoz
approved these changes
May 10, 2024
JordanTheToaster
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Refactor timers a bit to be a little less gross and more readable, also fix a couple of bugs.
Rationale behind Changes
There was a bunch of repeated code and legacy naming which wasn't obvious to what it was, which I wanted to sort out.
Also fixed the slight inaccuracy of counting time for framerates which weren't whole numbers.
Correct start cycles so they are on clock tick boundaries.
Disable sending V/H sync interrupts etc when SINT (this is the PCRTC initialization mode) is enabled, nothing happens during this sequence on a PS2.
Suggested Testing Steps
Test a whole bunch of things, make sure everything is fine.
Unfortunately I don't think anything is fixed :(
Double unfortunate this required a savestate bump.