Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Disassembly is a pain point. There are multiple disassembler interfaces, and the "good" one we don't even use properly.
I've disabled another heuristic to prevent pseudo ops like
li
,Rationale behind Changes
Fixes: #10702
Suggested Testing Steps
See if pseudo instructions such as
li
shows up in the disassembly widget, or in the breakpoint listing.I did not see any conflicts with #10224, to be really sure though, maybe merge that pr first.