New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new Ico version based on Redump Database #11103
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting a contribution to PCSX2
As this is your first pull request, please be aware of the contributing guidelines.
Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.
Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!
According to redump this was a "Preview" version, it may be work labelling it correctly as such as we do with others. |
What's the label on the disc? The ELF just may be misnamed. |
According to Redump, the printings on the label are : Preview PAL ICO December 2001 |
Do you not possess the disc to check? Using a random comment on redump as a source of truth is a bit iffy. |
I wish I did, unfortunately I do not (yet). I am currently tracking it, as I have good reasons to think this very build was used by a French broadcast channel at the time (the broadcast includes a red GUI when Yorna gets kidnaped, that is not present on any other known build, meaning there was indeed a European press release still unaccounted for, which this one could match). Does anyone have more info regarding this disc maybe ? If the trail feels like it's too thin, I can understand this PR might be dropped |
I'm mainly just a bit iffy about relying on redump's "internal serial". For PSX games, I've found it to be incorrect in many cases. |
I did not know that, I understand. Edit : Note that on the bright side, this serial might be wrong, but so far it's unique, not referring to any other games. |
It doesn't make sense to add something to the DB which can't be tested. Which you can't do if you don't have the disc. |
Would a press release qualify as public release ? If so, I will try and reach NomadColossus to make sure this is indeed is a press preview (probably the one I was referring to, I will try and confirm that too). If possible, I will also try to check with him if indeed the serial is the same as reported on Redump. If anyone have this elusive disk at hand, or knowledge regarding it's whereabouts, feel free to enlighten me. |
Still working on getting my hands on the disk, but in the meantime, I found that this entry does exist in the current RedumpDatabase.yaml and it matches the internal serial of "SCES-00000" (but it's only logical if the source is the same). I'm also trying to confirm unequivocally this was indeed a press release, and not prototype. |
Thanks for the update |
While studying Ico workarounds (and being amazed by it), I discovered on Redump that there is one (quite new) version not documented in the GameIndex.yaml
I do realize that serial "SCES-00000" can look like a generic placeholder, which could spell trouble here. Yet, so far, it's the only know game on Redump to sport this weird serial.
Rationale behind Changes
Since all Ico versions uses the
moveHandler: "MV_Ico"
to fixes depth buffer post-processing, I though it would be appropriate to populate this entry as well, for completeness sake.Suggested Testing Steps
Make sure it doesn't interfere with the main Ico entries, but can't really see how it might. Or if there is other undocumented "SCES-00000" discs.
It's my first PR here, I did my best to match writing style and list ordering, but be welcome to correct me if I did anything wrong.