New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt: added Catppuccin Mocha theme #11081
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting a contribution to PCSX2
As this is your first pull request, please be aware of the contributing guidelines.
Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.
Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!
Most of these are inherent to other themes already present so I wouldn't put too much weight into that. Besides that it looks great to me so I approve. |
Yeah, unfortunately palette changes are sometimes insufficient, and you need to use stylesheets. Just have to be careful, because I've found styling some elements breaks the native popup dialogs on MacOS... :( |
also i don't have a MacOS computer to test with |
@RedDevilus if you're talking about the icon color i'll need to change the color when it's selected which i was already planning on doing. |
im having trouble getting incremental builds to work in visual studio with this setup does anyone know why? |
Join the Discord you can ask for help there. |
Qt: added built-in qss theme CatppuccinMocha
You'd have to be more specific. VS builds should just be a matter of downloading and extracting the deps pack, opening the solution, and clicking build. See https://github.com/PCSX2/pcsx2/wiki/12-Building-on-Windows |
@stenzek what i meant to say is that it won't do a build if i change the .qss file it doesn't seem to be keeping track of it, it only updates after a rebuild |
Oh, I see. Couple of suggestions then:
|
Description of Changes
added the Catppuccin Mocha theme
there are still some issue i don't know if can be fixed with just a theme:
emulation>maximum frame latency
are also too low contrastgraphics>osd
the box where the options are there looks odd
also other Catppuccin flavors should also probably be added if mocha is