Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: added Catppuccin Mocha theme #11081

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

BPplays
Copy link

@BPplays BPplays commented Apr 15, 2024

Description of Changes

added the Catppuccin Mocha theme

there are still some issue i don't know if can be fixed with just a theme:

  • the icons are not themed they are just white
  • the search bar text is not themed
  • seperators are not themed
  • non-highlighted outlines are not themed
  • check boxes are too low contrast
  • dropdown menus have gradients which doesn't look very good
  • some selection boxes with arrows on the side like emulation>maximum frame latency are also too low contrast
  • some sub-menus are weird colors like graphics>osd the box where the options are there looks odd
  • the window title on windows is not themed (this is probably not fixable)

also other Catppuccin flavors should also probably be added if mocha is

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a contribution to PCSX2

As this is your first pull request, please be aware of the contributing guidelines.

Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.

Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!

@JordanTheToaster
Copy link
Contributor

Most of these are inherent to other themes already present so I wouldn't put too much weight into that. Besides that it looks great to me so I approve.

@stenzek
Copy link
Member

stenzek commented Apr 15, 2024

Yeah, unfortunately palette changes are sometimes insufficient, and you need to use stylesheets.

Just have to be careful, because I've found styling some elements breaks the native popup dialogs on MacOS... :(

@BPplays
Copy link
Author

BPplays commented Apr 24, 2024

im trying to make a qss theme and i've done a little with custom.qss but i would like to do an embeded qss theme if possible but im not really familiar with how i would add a file to the build system or reference it from the code.
maybe it could go somewhere like ./resources/qss/CatppuccinMocha.qss?

i think i've got it working now

also i don't have a MacOS computer to test with

@RedDevilus
Copy link
Contributor

I would also suggest, rechecking all elements. The contrast differences are pretty hard on the eyes on specific location.

For example:
image

For a Darkish Palette, this is quite bright and even painful for light users.

@BPplays
Copy link
Author

BPplays commented Apr 24, 2024

@RedDevilus if you're talking about the icon color i'll need to change the color when it's selected which i was already planning on doing.
if you're talking about the light color with dark text then another option is to try and use one of the lighter grey colors in the theme instead of the bright accent color because all the the accent colors are decently bright

@BPplays
Copy link
Author

BPplays commented Apr 25, 2024

im having trouble getting incremental builds to work in visual studio with this setup does anyone know why?
there are also still quite a few issues with the theme

@JordanTheToaster
Copy link
Contributor

im having trouble getting incremental builds to work in visual studio with this setup does anyone know why? there are also still quite a few issues with the theme

Join the Discord you can ask for help there.

Qt: added built-in qss theme CatppuccinMocha
@stenzek
Copy link
Member

stenzek commented Apr 25, 2024

You'd have to be more specific. VS builds should just be a matter of downloading and extracting the deps pack, opening the solution, and clicking build. See https://github.com/PCSX2/pcsx2/wiki/12-Building-on-Windows

@BPplays
Copy link
Author

BPplays commented Apr 25, 2024

@stenzek what i meant to say is that it won't do a build if i change the .qss file it doesn't seem to be keeping track of it, it only updates after a rebuild

@stenzek
Copy link
Member

stenzek commented Apr 26, 2024

Oh, I see. Couple of suggestions then:

  1. Just hardcode a path on disk, that way you don't need to recompile.
  2. Or, right click resources.qrc, and click compile. IIRC this should force it to regenerate the cpp file. The dirty tracking in msbuild is a bit iffy, I've never bothered to look into if it can be improved..

@Daisouji
Copy link
Contributor

Daisouji commented Apr 28, 2024

image

No need to add it as a resource. I added that bit ago to cover .qss files. Just name it Custom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants