Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Link with ffmpeg for AppImage #10932

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

CI: Link with ffmpeg for AppImage #10932

wants to merge 1 commit into from

Conversation

stenzek
Copy link
Member

@stenzek stenzek commented Mar 15, 2024

Description of Changes

Should cause linuxdeploy to pull in ffmpeg.

Rationale behind Changes

Increase distribution compatibility.
Size will increase, but the appimage is already huge, so whatever. Packaging on Linux just sucks to begin with.

Suggested Testing Steps

Test video capture with AppImage.

@RedDevilus
Copy link
Contributor

Should ffmpeg also best be updated to 6.1.1? https://ffmpeg.org/download.html

@stenzek
Copy link
Member Author

stenzek commented Mar 15, 2024

No, because it's using (and pulling in) the system libraries.

@stenzek
Copy link
Member Author

stenzek commented Mar 15, 2024

48MB -> 94MB.... not worth it for a feature that barely anyone uses, IMO.

If you want video capture, I'd say just use the flatpak...

@TheTechnician27
Copy link
Contributor

TheTechnician27 commented Mar 15, 2024

Made a 7-minute video and found no defect in it. Downloaded the AppImage and used on Manjaro.

Copy link

@AmyRoxwell AmyRoxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works On EndeavourOS (Arch Linux), Also, HEVC and other encoders on AMD gpus work on mesa drivers! (nvm, double checked with a couple of games and it's using the cpu for the encoding not matter what encoder you choose....)

@AmyRoxwell
Copy link

AmyRoxwell commented Mar 15, 2024

Well, we have one problem, it doesn't utilize the gpu, it does all of it using the CPU, even if you have VAAPI, HEVC and other packages that should make it work on the gpu (lots of them included on the Mesa drivers + they utilize the gpu on stuff like obs), is there maybe some arguments that need to be put on the video encoder to make it utilize the gpu?

@stenzek
Copy link
Member Author

stenzek commented Mar 16, 2024

Meh. Gonna draft it I think. Distributing software on Linux just sucks.

The best move would probably be to build our own ffmpeg with the required modules enabled. But that also means building libx264 etc, and I really can't be arsed.

@stenzek stenzek marked this pull request as draft March 16, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants