Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade three.js to version 161 #135

Merged
merged 7 commits into from May 13, 2024
Merged

Upgrade three.js to version 161 #135

merged 7 commits into from May 13, 2024

Conversation

biharygergo
Copy link
Contributor

@biharygergo biharygergo commented May 10, 2024 •
edited

Updated to a much newer three.js version.

Main changes:

  • Removed deprecated function calls and assignments (.count, addAttribute)
  • Updated ID encoding to work with new linear color space (default in newer Three.js versions)
  • Updated default colors values to work well (be more visible) with the new color space defaults
image

Issues to fix:

  • Colors are slightly different, need to research why (especially sequence lines)
  • Code formatting, cleanup
  • Validate all existing features work as they should

@biharygergo biharygergo marked this pull request as ready for review May 13, 2024 12:45
cannoneyed
cannoneyed approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@cannoneyed cannoneyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for fixing/upgrading

@cannoneyed cannoneyed merged commit d596573 into PAIR-code:main May 13, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cannoneyed cannoneyed cannoneyed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@biharygergo @cannoneyed