Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support downloading the composition as MIDI #25

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

youralien
Copy link
Collaborator

@youralien youralien commented Nov 18, 2021

Summary: A download button was added to the controls, which downloads the notes in the editor as a MIDI file.

In the process of making this work, the following changes were made:

  • Needed to update @magenta/music to latest version in order to overcome an error when calling sequenceProtoToMidi (see link)
  • Needed to remove uses of babel which was failing at transpiling to ES6 in order for us to use these new @magenta/music package without errors
  • Required node version 12 in the package.json engines. This will ensure someone who is running node 16 isn't horribly confused why they cant yarn install (like I initially was)
  • Changed some case sensitive imports because typescript on Linux actually cares about some case sensitivity. Ended up just deving on OSX in the end

Tests: Deployed to https://pair-code.github.io/cococo/. It successfully saves the music after Coconet infills several voices

@youralien youralien force-pushed the updates-for-blog branch 5 times, most recently from 93548b6 to bc675f3 Compare November 18, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant