Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude vesting events past a grant cancellation from the Vesting History #15

Merged
merged 4 commits into from Apr 17, 2024

Conversation

franckc
Copy link
Contributor

@franckc franckc commented Mar 18, 2024

Fix for #14

  • Added a new cancelled property on the vesting event object returned by the server.
  • The UI now checks on that property when using events in the VestingHistory and VestingBar component
  • Added unit tests for the new code. Tweaked some older unit tests to use UTC tz otherwise they were failing when ran on a host in Daylight saving time :)

Here is a couple of snapshot showing the old vs new behavior with a grant having a cancellation date of 2021-06-15

UI before (notice how it shows vesting events past the cancellation date):
Screenshot 2024-03-18 at 11 17 28 AM

UI after (notice how it dos not show vesting events past the cancellation date):
Screenshot 2024-03-18 at 11 27 44 AM

@franckc franckc requested a review from shahthepro March 18, 2024 18:30
Copy link
Contributor

@shahthepro shahthepro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@franckc franckc merged commit 3a2fcdf into master Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants