Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vesting Schedule includes vesting events from cancelled grants #14

Open
franckc opened this issue Mar 6, 2024 · 0 comments
Open

Vesting Schedule includes vesting events from cancelled grants #14

franckc opened this issue Mar 6, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@franckc
Copy link
Contributor

franckc commented Mar 6, 2024

Issue description

The front-end logic for the "Vesting Schedule" component does not account properly for grants that have been cancelled at a certain date. It only checks on the vesting event date vis-a-vis the current date. It should also include checking whether the vesting event is invalid because it occurred past the grant's cancellation date.

See code:

{momentDate < moment.now() ? 'vested' : 'unvested'}

Impact

  • If a user has a grant that was cancelled, they'll still see vesting events as "vested" past the grant cancellation date. This is confusing.
  • Note that the total balance displaying on the UI and also the logic for withdrawal are correct - they account properly for grant cancellation. So there is no financial impact.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant