Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix daily apy #376

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix daily apy #376

wants to merge 2 commits into from

Conversation

rolandpo
Copy link
Contributor

remove normalisation to daily blocks in daily apy calculation, since yield is based on time intervals, add backfill script

sparrowDom
sparrowDom requested changes Sep 29, 2023
View reviewed changes
Copy link
Member

@sparrowDom sparrowDom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the normalisation to a day within the formula is required. Happy to be convinced otherwise.

eagleproject/core/blockchain/harvest/transaction_history.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sparrowDom sparrowDom sparrowDom requested changes

@shahthepro shahthepro Awaiting requested review from shahthepro

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rolandpo @sparrowDom