Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy 092 - wOETH on Base #2022

Merged
merged 1 commit into from May 2, 2024
Merged

Conversation

shahthepro
Copy link
Collaborator


If you made a contract change, make sure to complete the checklist below before merging it in master.

Refer to our documentation for more details about contract security best practices.

Contract change checklist:

  • Code reviewed by 2 reviewers.
  • Copy & paste code review security checklist below this checklist.
  • Unit tests pass
  • Slither tests pass with no warning
  • Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

Copy link

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against 2dbbc14

@DanielVF
Copy link
Member

Is this missing the code for the proxy contract?

@shahthepro
Copy link
Collaborator Author

@DanielVF The proxy code and deployment file are already there on the base branch. This is just the deployment PR

@DanielVF
Copy link
Member

DanielVF commented May 2, 2024

Gotcha. The proxy code is merged into thePraneshASP/aerodrome-amo branch, which is it's not in master or added to this PR.

- [x] All deployed contracts are listed in the deploy PR's description
- [x] Deployed contract's verified code (and all dependencies) match the code in master
- [x] The transactions that interacted with the newly deployed contract match the deploy script.

@DanielVF DanielVF merged commit 563775d into PraneshASP/aerodrome-amo May 2, 2024
7 of 14 checks passed
@DanielVF DanielVF deleted the shah/deploy-092 branch May 2, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants