Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proposal to add Guardian to Timelock #2021

Merged
merged 11 commits into from May 8, 2024
Merged

Conversation

shahthepro
Copy link
Collaborator

@shahthepro shahthepro commented Apr 17, 2024

Proposal


If you made a contract change, make sure to complete the checklist below before merging it in master.

Refer to our documentation for more details about contract security best practices.

Contract change checklist:

  • Code reviewed by 2 reviewers.
  • Copy & paste code review security checklist below this checklist.
  • Unit tests pass
  • Slither tests pass with no warning
  • Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

Copy link

github-actions bot commented Apr 17, 2024

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against 2f56cb4

DanielVF
DanielVF previously approved these changes May 8, 2024
Copy link
Member

@DanielVF DanielVF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code checked.

Have locally run the fork tests.

@shahthepro shahthepro requested a review from DanielVF May 8, 2024 13:50
@DanielVF DanielVF merged commit 1d37d30 into master May 8, 2024
8 of 13 checks passed
@DanielVF DanielVF deleted the shah/guardian-proposal branch May 8, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants