Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix some comments #2005

Merged
merged 1 commit into from May 8, 2024
Merged

chore: fix some comments #2005

merged 1 commit into from May 8, 2024

Conversation

depthlending
Copy link
Contributor

If you made a contract change, make sure to complete the checklist below before merging it in master.

Refer to our documentation for more details about contract security best practices.

Contract change checklist:

  • Code reviewed by 2 reviewers.
  • Copy & paste code review security checklist below this checklist.
  • Unit tests pass
  • Slither tests pass with no warning
  • Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

@depthlending
chore: fix some comments
8251ea2 
Signed-off-by: depthlending <bikangning@outlook.com>
@DanielVF
Copy link
Member

Thanks, we'll take a look!

@depthlending
Copy link
Contributor Author

Anything need I to do?

@DanielVF DanielVF added the contracts Works related to contracts label May 8, 2024
sparrowDom
sparrowDom approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@sparrowDom sparrowDom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks for this 👍

@sparrowDom sparrowDom merged commit d3bff43 into OriginProtocol:master May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielVF DanielVF DanielVF approved these changes

@sparrowDom sparrowDom sparrowDom approved these changes

@naddison36 naddison36 Awaiting requested review from naddison36 naddison36 is a code owner

@shahthepro shahthepro Awaiting requested review from shahthepro shahthepro is a code owner

Assignees
No one assigned
Labels
contracts Works related to contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@depthlending @DanielVF @sparrowDom