Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minting and redeeming only using WETH #1965

Closed
wants to merge 4 commits into from
Closed

Conversation

sparrowDom
Copy link
Member

Draft mock up of how VaultCore would look allowing for only WETH mints / redeems

@sparrowDom sparrowDom self-assigned this Dec 29, 2023
Copy link

github-actions bot commented Dec 29, 2023

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against 7ff8346

@sparrowDom sparrowDom changed the title initial commit of minting and redeeming only using WETH Minting and redeeming only using WETH Dec 29, 2023
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (0572191) 59.60% compared to head (5b4a4d5) 0.00%.

❗ Current head 5b4a4d5 differs from pull request most recent head 7ff8346. Consider uploading reports for the commit 7ff8346 to get more accurate results

Files Patch % Lines
contracts/contracts/vault/OETHVaultCore.sol 0.00% 46 Missing ⚠️
contracts/contracts/vault/VaultCore.sol 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #1965       +/-   ##
==========================================
- Coverage   59.60%   0.00%   -59.61%     
==========================================
  Files          55      56        +1     
  Lines        2820    2866       +46     
  Branches      728     747       +19     
==========================================
- Hits         1681       0     -1681     
- Misses       1136    2866     +1730     
+ Partials        3       0        -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahthepro
Copy link
Collaborator

@sparrowDom Any reason to keep this PR around?

@DanielVF
Copy link
Member

DanielVF commented May 8, 2024

Closing this PR. Code used was #1995

@DanielVF DanielVF closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants