Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparrow dom/balancer amo #1904

Draft
wants to merge 13 commits into
base: nicka/amo-frxeth
Choose a base branch
from
Draft

Conversation

sparrowDom
Copy link
Member

If you made a contract change, make sure to complete the checklist below before merging it in master.

Refer to our documentation for more details about contract security best practices.

Contract change checklist:

  • Code reviewed by 2 reviewers.
  • Copy & paste code review security checklist below this checklist.
  • Unit tests pass
  • Slither tests pass with no warning
  • Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

@rafaelugolini rafaelugolini temporarily deployed to preview-ousd-sparrowdom-veoezz October 30, 2023 13:44 Inactive
@rafaelugolini rafaelugolini temporarily deployed to preview-oeth-sparrowdom-qkoh95 October 30, 2023 13:44 Inactive
@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against 9936bd4

@sparrowDom sparrowDom temporarily deployed to preview-oeth-sparrowdom-qkoh95 October 30, 2023 13:56 Inactive
@sparrowDom sparrowDom temporarily deployed to preview-ousd-sparrowdom-veoezz October 30, 2023 13:56 Inactive
@sparrowDom sparrowDom temporarily deployed to preview-oeth-sparrowdom-qkoh95 October 30, 2023 15:47 Inactive
@sparrowDom sparrowDom temporarily deployed to preview-ousd-sparrowdom-veoezz October 30, 2023 15:47 Inactive
@sparrowDom sparrowDom temporarily deployed to preview-oeth-sparrowdom-qkoh95 October 30, 2023 22:53 Inactive
@sparrowDom sparrowDom temporarily deployed to preview-ousd-sparrowdom-veoezz October 30, 2023 22:53 Inactive
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #1904 (9936bd4) into nicka/amo-frxeth (fbadbbd) will decrease coverage by 69.19%.
Report is 18 commits behind head on nicka/amo-frxeth.
The diff coverage is 0.00%.

❗ Current head 9936bd4 differs from pull request most recent head 6232a49. Consider uploading reports for the commit 6232a49 to get more accurate results

@@                 Coverage Diff                  @@
##           nicka/amo-frxeth   #1904       +/-   ##
====================================================
- Coverage             69.18%   0.00%   -69.19%     
====================================================
  Files                    57      57               
  Lines                  3067    3071        +4     
  Branches                767     761        -6     
====================================================
- Hits                   2122       0     -2122     
- Misses                  942    3071     +2129     
+ Partials                  3       0        -3     
Files Coverage Δ
contracts/contracts/strategies/FraxETHStrategy.sol 0.00% <ø> (-100.00%) ⬇️
...ntracts/strategies/amo/BaseBalancerAMOStrategy.sol 0.00% <ø> (ø)
...s/strategies/balancer/BalancerMetaPoolStrategy.sol 0.00% <ø> (-7.58%) ⬇️
...ontracts/strategies/amo/BalancerEthAMOStrategy.sol 0.00% <0.00%> (ø)
...ntracts/strategies/amo/ConvexFrxETHAMOStrategy.sol 0.00% <0.00%> (-100.00%) ⬇️
...ontracts/strategies/amo/ConvexOUSDMetaStrategy.sol 0.00% <0.00%> (-88.50%) ⬇️
...racts/contracts/strategies/amo/BaseAMOStrategy.sol 0.00% <0.00%> (-72.79%) ⬇️

... and 39 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sparrowDom sparrowDom temporarily deployed to preview-oeth-sparrowdom-qkoh95 November 2, 2023 12:48 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants