Add deployment target to export recipe as json in addition to zip

[MikeAlhayek]

Fix #15383

I am trying to avoid introducing a breaking change here. But we can cleanup the code if we change the definition of the DeploymentPlanResult class.

@sebastienros if you agree, I like to introduce this low-risk breaking change. The class DeploymentPlanResult should be light and treated as a base class. So it should not depend on IFileBuilder

I like to add another class FileDeploymentPlanResult that inherits from DeploymentPlanResult just like MemoryDeploymentPlanResult. The class FileDeploymentPlanResult will take an instance of the IFileBuilder and write the content to the file.

Are you good with introducing this low risk breaking change?

[ns8482e]

@MikeAlhayek I would suggest to keep only one Target "File Download" as currently available.
Provide two different button using bootstrap dropdown buttons instead of just "Select".

Html can be changed using shape and alternates - You can move following code to a new shape Template that provides alternates for deployment targets.

e.g.

• Move following to a shape like DeploymentTargetAction.cshtml
  https://github.com/OrchardCMS/OrchardCore/blob/bbbc79ab90e88bac4a13efeef1fcb5ee32932cef/src/OrchardCore.Modules/OrchardCore.Contents/Views/Items/ExportContentToDeploymentTarget-ActionDeploymentTarget.Modal.cshtml#L23C33-L33C39
• Add new property Identifier to deployment target that can be use to add alternate
• Replace the code with <shape> tag, that could add alternates based on DeploymentTarget Identifier (if exists)
• Add alternate for File Downlaod to override Select button and replace with bootstrap dropdown buttons with two buttons.
• Provide flag to route for compressed based on button clicked to controller, and download respective file

[MikeAlhayek]

I am trying to avoid using shapes here. I am thinking to just add another option to the deployment source that would allow providing formats. When formats are available, we'll just render drop down menu. Also, I am also considering supporting a single additional option "compressed" true/false. This may be all we need without complicating things

[ns8482e]

I don't believe it complicates the things. It's about right approach to a problem. Here "Targets" are kinda mode of delivery of recipes. "File Download" is just one mode of delivery - so adding two Targets for same mode of delivery- is not right solution

[MikeAlhayek]

@ns8482e I don't want to convert to shapes here. However, I added an optional support for Formats. If formats are defined, we'll show a drop down menu with the available formats.

[ns8482e]

string.Format or interpolated string

[ns8482e]

same here string.Format or use interpolated string

[ns8482e]

How about having common Dictonary/Json like structure here to hold any kind of properties?

e.g. In future if we decide to add blob target, it could save connection string property

[Piedone]

I believe this came up at a meeting, but can't remember the conclusion: what about Media files, that require a ZIP file?

[MikeAlhayek]

I have to try and see how it'll work when exporting media. I have not had time to try it out

[github-actions]

This pull request has merge conflicts. Please resolve those before requesting a review.