Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lib: Add colors to be aligned with the design #106

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Jan 31, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Closes #103.

Description

Provide sequential pink, sequential yellow, default categorical colors and emphasized categorical colors.

Motivation & Context

More colors and flexibility for people.
Realign colors with the design with 9bec574.
Proposal to make lighter colors darker on dark mode with cd3f335. Feel free to separate this commit from the PR.
Proposal to handle axis colors differently (even if I can't spot any visual change) with 2dab014. Feel free to separate this commit from the PR.

⚠️ TODO after this PR is merged:

  • Change the name of categoricalColors, here are some ideas:
    • color as ApacheEcharts does, imo it can be disturbing for newcomers
    • odsColor maybe we should prefix all our parameters
    • odsGraphColor to be more understandable

Types of change

  • New feature (non-breaking change which adds functionality)

Test checklist

Please check that the following tests projects are still working:

  • docs/examples
  • test/angular-ngx-echarts
  • test/angular-echarts
  • test/html
  • test/react
  • test/vue
  • test/examples/bar-line-chart
  • test/examples/single-line-chart
  • test/examples/timeseries-chart

Copy link

netlify bot commented Jan 31, 2024

Deploy Preview for ods-charts ready!

Name Link
🔨 Latest commit 2dab014
🔍 Latest deploy log https://app.netlify.com/sites/ods-charts/deploys/662b5b27ec6fd400089f4e0c
😎 Deploy Preview https://deploy-preview-106--ods-charts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@louismaximepiton louismaximepiton added the enhancement New feature or request label Mar 12, 2024
@louismaximepiton louismaximepiton marked this pull request as draft March 15, 2024 14:31
@louismaximepiton louismaximepiton changed the title Add categorical and pink colors Lib: Add colors to be aligned with the design Apr 17, 2024
@louismaximepiton louismaximepiton marked this pull request as ready for review April 17, 2024 14:34
@jacques-lebourgeois
Copy link
Member

Ok to merge this PR and create a technicall one to rename CategoricalColors and SequentialColors to Colors.

( ODSChartsColorsSet, ODSChartsColor, ODSChartsCustomColor, ...)

@julien-deramond julien-deramond self-requested a review May 30, 2024 07:07
@julien-deramond
Copy link
Member

Before merging it, we need to define/precise the exact rules with the designers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request library on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reference: Dataviz colors
3 participants