-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lib: Add colors to be aligned with the design #106
Open
louismaximepiton
wants to merge
9
commits into
Orange-OpenSource:main
Choose a base branch
from
louismaximepiton:main-lmp-add-colors
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Lib: Add colors to be aligned with the design #106
louismaximepiton
wants to merge
9
commits into
Orange-OpenSource:main
from
louismaximepiton:main-lmp-add-colors
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ods-charts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
louismaximepiton
changed the title
Add categorical and pink colors
Lib: Add colors to be aligned with the design
Apr 17, 2024
Ok to merge this PR and create a technicall one to rename CategoricalColors and SequentialColors to Colors. ( ODSChartsColorsSet, ODSChartsColor, ODSChartsCustomColor, ...) |
jacques-lebourgeois
approved these changes
May 28, 2024
Before merging it, we need to define/precise the exact rules with the designers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please transform
- [ ]
into- (NA)
in the description when things are not applicableRelated issues
Closes #103.
Description
Provide sequential pink, sequential yellow, default categorical colors and emphasized categorical colors.
Motivation & Context
More colors and flexibility for people.
Realign colors with the design with 9bec574.
Proposal to make lighter colors darker on dark mode with cd3f335. Feel free to separate this commit from the PR.
Proposal to handle axis colors differently (even if I can't spot any visual change) with 2dab014. Feel free to separate this commit from the PR.
categoricalColors
, here are some ideas:color
as ApacheEcharts does, imo it can be disturbing for newcomersodsColor
maybe we should prefix all our parametersodsGraphColor
to be more understandableTypes of change
Test checklist
Please check that the following tests projects are still working:
docs/examples
test/angular-ngx-echarts
test/angular-echarts
test/html
test/react
test/vue
test/examples/bar-line-chart
test/examples/single-line-chart
test/examples/timeseries-chart