OP-21771: springboot3 upgrade aftereffects swagger failed so migrating from SpringFox to SpringDoc. #118
Conversation
rahul-chekuri
requested review from
sanopsmx,
j-sandy,
kirangodishala,
aman-agrawal,
SusmithaGundu and
jsoundar22
|
@rahul-chekuri We need to resolve conflict before merge. So could you please do the needful ? |
Sure |
…g from SpringFox to SpringDoc.
…S-1.30.x-master-adhoc
Done |
|
@rahul-chekuri please also clean-up the unnecessary commits from this PR like revert custom snapshot etc., by doing git rebase instead of merge. |
.github/workflows/kork-publish.yml
Outdated
| @@ -27,71 +27,71 @@ jobs: | |||
| env: | |||
| NEXUS_VERSION: 1-0-SNAPSHOT | |||
| run: | | |||
|
|
|||
There was a problem hiding this comment.
@rahul-chekuri Workflow changes are the part of Springfox to springdoc ? And are they required ?
There was a problem hiding this comment.
Somehow indentation is getting corrected and making it as an item for commit. I am unable to avoid that. Let me give it one hard shot and get rid of this file from the PR. :)
| * At the service(child services to Kork) level, while registering converters, somehow the ordering of HttpMessageConverters is getting disturbed. | ||
| * This configuration aligns it properly and there by fix decoding issue of swagger responses. | ||
| * | ||
| * ref docs: https://github.com/springdoc/springdoc.github.io/issues/52 |
There was a problem hiding this comment.
As per this ref: springdoc/springdoc.github.io#52
Issues was reported with springdoc 1.6.x version. Is this issue still exist in 2.0.3 ?
There was a problem hiding this comment.
|
Cleaning up unnecessary commits is taking time. Created a new PR with the changes from here #120 so closing this. |
https://devopsmx.atlassian.net/browse/OP-21771
SpringFox is not compatible with springboot3 so using SpringDoc.
springfox/springfox#3983
This is the migration guide followed.
https://springdoc.org/#migrating-from-springfox