Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PostprocessBundle.cmake to include /opt/homebrew/lib #1425

Merged
merged 2 commits into from
Sep 9, 2023
Merged

Update PostprocessBundle.cmake to include /opt/homebrew/lib #1425

merged 2 commits into from
Sep 9, 2023

Conversation

telephono
Copy link
Contributor

Homebrew on macOS arm64 lives in /opt/homebrew per default. Add /opt/homebrew/lib to PostprocessBundle.cmake's extra_dirs. Without this, libsharpyuv.0.dylib cannot be found during bundeling resulting in the following error:

CMake Error at /Users/xxx/Sources/OpenXcom/cmake/modules/PostprocessBundle.cmake:44 (_message):
  otool -l failed: 1

  error: /Library/Developer/CommandLineTools/usr/bin/otool-classic: can't
  open file: @rpath/libsharpyuv.0.dylib (No such file or directory)

Call Stack (most recent call first):
  /opt/homebrew/Cellar/cmake/3.27.4/share/cmake/Modules/BundleUtilities.cmake:458 (message)
  /opt/homebrew/Cellar/cmake/3.27.4/share/cmake/Modules/BundleUtilities.cmake:527 (get_item_rpaths)
  /opt/homebrew/Cellar/cmake/3.27.4/share/cmake/Modules/BundleUtilities.cmake:649 (set_bundle_key_values)
  /opt/homebrew/Cellar/cmake/3.27.4/share/cmake/Modules/BundleUtilities.cmake:933 (get_bundle_keys)
  /Users/xxx/Sources/OpenXcom/cmake/modules/PostprocessBundle.cmake:50 (fixup_bundle)


make[2]: *** [openxcom.app/Contents/MacOS/openxcom] Error 1
make[2]: *** Deleting file `openxcom.app/Contents/MacOS/openxcom'
make[1]: *** [src/CMakeFiles/openxcom.dir/all] Error 2
make: *** [all] Error 2

Homebrew on macOS arm64 lives in /opt/homebrew per default. Without this, libsharpyuv cannot be found during bundeling.
@telephono
Copy link
Contributor Author

Sorry, didn't notice the change in line 50. I changed the file using GitHub's web editor...

@SupSuper SupSuper merged commit 2145081 into OpenXcom:master Sep 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants