Clang tidy #1286
Open
Clang tidy #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in addition to generating Makefiles or Ninja files. It can be used by various LLVM tooling like clang-tidy or YouCompleteMe
Ran: clang-tidy -p . -header-filter=".*" "-checks=-*,performance-inefficient-string-concatenation" -fix **/*.cpp To solve: warning: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation]
floor(3) as used previously is the libc floor, which takes a double always, so the cast to float is superfluous. floorf(3) would take a float argument, but instead of switching to that, use std::floor which has the proper overload for double/float, and as of C++11 also has one for integral types, so use that directly. The clang-tidy fixes were massaged manually, as it wasn't quite as smart.
The fixes that added std::move (C++11 only) were manually reverted again. This sprinkles a ton of const refs all over the place, obviating the need to copy-construct Position all the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various clang-tidy inspired cleanups, they shrink the binary size by about 4k :)
They should speed things up as the Position ctor will be called less often.
I'm a bit surprised about the float math though, sure on a i386 it was faster than double math, but these days?