Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crf ratecontrol support #70

Open
wants to merge 106 commits into
base: master
Choose a base branch
from

Conversation

kirithika7
Copy link

Add new rate control mode-crf that takes the cli -rc 2 and -crf value in [0-51]

Add new rate control mode-crf that takes the cli -rc  2 and -crf  value in [0-51]
@tianjunwork tianjunwork added the enhancement New feature or request label Jan 11, 2019
Signed-off-by: kirithika <kirithika@multicorewareinc.com>
Signed-off-by: kirithika <kirithika@multicorewareinc.com>
…edictBitsDup() in EbEncDecProcess.c

Signed-off-by: kirithika <kirithika@multicorewareinc.com>
EncodeLcu

This commit also has some cleanups done

Signed-off-by: kirithika <kirithika@multicorewareinc.com>
…avoid underflow while removing a single frame

Signed-off-by: kirithika <kirithika@multicorewareinc.com>
…in low level VBV

Signed-off-by: kirithika <kirithika@multicorewareinc.com>
…le lookahead for crf

Signed-off-by: kirithika <kirithika@multicorewareinc.com>
Signed-off-by: kirithika <kirithika@multicorewareinc.com>

# Conflicts:
#	Source/Lib/Codec/EbEncDecProcess.c
#	Source/Lib/Codec/EbPictureControlSet.c
Signed-off-by: kirithika <kirithika@multicorewareinc.com>
@tianjunwork
Copy link
Contributor

Hi @kirithika7, is there a way to use for example CRF=20 encoding, but also limit the maximum bitrate? If yes, could you add more usage example in the user guide? Thx.

tianjunwork and others added 3 commits October 17, 2019 09:11
Signed-off-by: Austin Hu <austin.hu@intel.com>
Signed-off-by: Austin Hu <austin.hu@intel.com>
1480c1 added a commit to 1480c1/SVT-HEVC that referenced this pull request Nov 13, 2019
Signed-off-by: Christopher Degawa <ccom@randomderp.com>
1480c1 added a commit to 1480c1/SVT-HEVC that referenced this pull request Nov 13, 2019
Signed-off-by: Christopher Degawa <ccom@randomderp.com>
@thjr
Copy link

thjr commented Feb 7, 2020

Is this going forward?

@Austin-Hu
Copy link
Contributor

Is this going forward?

Hi @thjr,

In order to merge the CRF implementation, we need to make sure that there isn't PSNR/SSIM BDRate regression. But due to the PSNR/SSIM BDRate drop issue caused by another PR #348 , we planed to fix it at first, then go ahead to merge this CRF PR. Thanks!

@shalin186
Copy link

Any updates on this PR? It has been opened for a long time.

@mxsrm
Copy link

mxsrm commented Aug 21, 2021

Any updates on this PR? It has been opened for a long time.

I'm pretty sure development on svt-hevc is dead.

@bigfatbrowncat
Copy link

Hi! What about this PR? What is needed to be fixed to upmerge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet