Use vbv bitrate and buffersize if set when checking level #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jun Tian <tianjun1.0@gmail.com>
tianjunwork
commented
Aug 11, 2020
| @@ -2355,7 +2355,8 @@ void* RateControlKernel(void *inputPtr) | |||
| contextPtr->framesInInterval[5] ++; | |||
| totalFrameInInterval--; | |||
| } | |||
| contextPtr->virtualBufferSize = (((EB_U64)sequenceControlSetPtr->staticConfig.targetBitRate*3) << RC_PRECISION) / (contextPtr->frameRate); | |||
| EB_U64 bufferSize = sequenceControlSetPtr->staticConfig.vbvBufsize ? sequenceControlSetPtr->staticConfig.vbvBufsize : (EB_U64)sequenceControlSetPtr->staticConfig.targetBitRate * 3; | |||
There was a problem hiding this comment.
Hi @hassount , not sure if this change is needed.
intelmark
reviewed
Aug 11, 2020
| @@ -2399,19 +2399,22 @@ static EB_ERRORTYPE VerifySettings(\ | |||
| return_error = EB_ErrorBadParameter; | |||
| } | |||
|
|
|||
| if ((config->level != 0) && (config->rateControlMode) && (config->tier == 0) && ((config->targetBitRate*2) > mainTierMaxBitRate[levelIdx])){ | |||
| uint32_t maxBitrate = config->vbvMaxrate ? config->vbvMaxrate : config->targetBitRate * 2; | |||
There was a problem hiding this comment.
hate seeing magic numbers here. Can 2 and 3 be constants with an appropriate name, or perhaps a comment why double or triple the target bitrate is being used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jun Tian tianjun1.0@gmail.com
Description
Use vbv bitrate and buffersize if set when checking level. If not, still use the existing logic.
Issue
closes #569
Author(s)
@tianjunwork
Performance impact
Merge method