New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup: Convert tabs to spaces and remove trailing spaces #302
base: master
Are you sure you want to change the base?
Conversation
b0166f9
to
d3a97ad
Compare
The style job now passes for tabs, carriage returns, and spaces and final newlines Should we enforce that now? |
Sure! |
Can this be updated as it is the remaining PR item for the 1.4 release and now is a good time to make these changes? There was another PR for cleanup (226) that is a bit older and can be withdrawn. |
I have excluded all of the files in #70 |
Hi Chris, PR70 will soon be merged hopefully. It is still preferable to include it for style conversion. |
I can open another PR with files specifically from 70 after it's merged, or would it be preferable to just merge style changes in one commit? |
Either is fine. Whatever you think can reduce your effort:) |
I can wait, main reason why I wish to merge this is so that in the future my pr's don't include so much whitespace changes |
… files Signed-off-by: Christopher Degawa <ccom@randomderp.com>
Signed-off-by: Christopher Degawa <ccom@randomderp.com>
WIll the patches be okay with the conversion of whitespaces? Mainly about the hashes
Also modified STYLE.md's sed to exclude .git, build,Bin, and png and added a command to append newlines to files if it doesn't have it. I checked the encoder guide and the pictures seem to not be corrupt