Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Convert tabs to spaces and remove trailing spaces #302

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

1480c1
Copy link
Member

@1480c1 1480c1 commented Aug 6, 2019

WIll the patches be okay with the conversion of whitespaces? Mainly about the hashes

Also modified STYLE.md's sed to exclude .git, build,Bin, and png and added a command to append newlines to files if it doesn't have it. I checked the encoder guide and the pictures seem to not be corrupt

@1480c1 1480c1 force-pushed the tabs branch 2 times, most recently from b0166f9 to d3a97ad Compare August 6, 2019 02:04
@1480c1
Copy link
Member Author

1480c1 commented Aug 6, 2019

The style job now passes for tabs, carriage returns, and spaces and final newlines

Should we enforce that now?

@tianjunwork
Copy link
Contributor

@1480c1 Thank you for taking the effort to fix the coding style. We intentionally postpone coding style clean up to avoid rebasing of #70. Once it is merge, could you perform clean up again? Thanks.

@tianjunwork tianjunwork added the Clean up A cleaner implementation or improved functionality label Aug 6, 2019
@1480c1
Copy link
Member Author

1480c1 commented Aug 6, 2019

Sure!

@intelmark
Copy link
Contributor

Can this be updated as it is the remaining PR item for the 1.4 release and now is a good time to make these changes? There was another PR for cleanup (226) that is a bit older and can be withdrawn.

@1480c1
Copy link
Member Author

1480c1 commented Aug 26, 2019

I have excluded all of the files in #70

@tianjunwork
Copy link
Contributor

Hi Chris, PR70 will soon be merged hopefully. It is still preferable to include it for style conversion.

@1480c1
Copy link
Member Author

1480c1 commented Aug 26, 2019

I can open another PR with files specifically from 70 after it's merged, or would it be preferable to just merge style changes in one commit?

@tianjunwork
Copy link
Contributor

Either is fine. Whatever you think can reduce your effort:)

@1480c1
Copy link
Member Author

1480c1 commented Aug 26, 2019

I can wait, main reason why I wish to merge this is so that in the future my pr's don't include so much whitespace changes

… files

Signed-off-by: Christopher Degawa <ccom@randomderp.com>
Signed-off-by: Christopher Degawa <ccom@randomderp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean up A cleaner implementation or improved functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants