New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix B-frame without positive reference frames as P-frame. #182
base: master
Are you sure you want to change the base?
Conversation
Hi Falei, if changing it from B to P, then there'll be no Bidir latter, this will affect the quality. |
@lijing0010 Thank you very much, Does this have noteworthy quality loss? |
I found this patch could cause deadlock problem with
|
|
When getting the same quality, the B frame can gets higher compressing rate than the P frame for Bidirect mode is enabled |
Hi @luofalei , Agree with @kelvinhu325 that B frame could get higher compression rate. And the picture type has been assigned in PictureDecisionKernel() function with some conditions, such as GOP info, IDR, CRA, etc., but not depends on whether it has positive ref frame or not (in random access). Thanks! |
The
B frame
in the key position only have negative reference frames in the ramdom access prediction structure. For example the frames whose pictureNumber is 8 (POC 8
) could only reference framePOC 0
.Using
B_SLICE
for this picture would bring in more header bits in the bit-stream and may bring in more computation.So I suggest to fix their type as
P-frame
.