Embed images via next-images #145
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xMartin
commented
Apr 24, 2020
xMartin
commented
- Cache-busting via content hash in filename
- Sharing image as an example
* Cache-busting via content hash in filename
|
This pull request is being automatically deployed with Vercel (learn more). |
|
When working with sharing images before I noticed that cache busting doesn't always help. Especially for fb I always need to re-crawl the website after updating the image using the debug tools: https://developers.facebook.com/tools/debug/ |
|
@Twissi Yes, Facebook caches the image for a day or so but if there's no change in the file name for me it didn't get ever updated, also not with the debugger. Independently of that, we should have cache busting for all assets. |
|
@mamhoff Can you please update the branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.