Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

136 fix open graph image #144

Merged
merged 1 commit into from
Apr 23, 2020
Merged

136 fix open graph image #144

merged 1 commit into from
Apr 23, 2020

Conversation

xMartin
Copy link
Member

@xMartin xMartin commented Apr 23, 2020

This is a simple quick fix, changing the image dimensions and adding the "OpenTechSchool" logo.

@vercel
Copy link

vercel bot commented Apr 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/opentechschool/websitenext/gypin5xc0
✅ Preview: https://websitenext-git-136-fix-open-graph-image.opentechschool.now.sh

As of Facebook's recommendation it's 1080 wide with a ratio of 1:91

fixes 136
fixes 137
@gsambrotta
Copy link
Member

@xMartin i also worked on this issue 🙃 look at here please #142
From my research, i think an image that wide will fit many social in particular whatsapp, Linkedin and twitter small card.
I also find out that whatsapp has a specific size and file size that needs to be follow.

@xMartin
Copy link
Member Author

xMartin commented Apr 23, 2020

@gsambrotta See my comments on your PR.

@xMartin
Copy link
Member Author

xMartin commented Apr 23, 2020

I will just merge because it doesn't change much and hopefully fixed the cut away stuff. We can still work on it for other cases.

@xMartin xMartin merged commit bbd6f05 into master Apr 23, 2020
@xMartin xMartin deleted the 136-fix-open-graph-image branch April 23, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants