New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include URIs for PKCS#11 objects #3130
Open
sarroutbi
wants to merge
1
commit into
OpenSC:master
Choose a base branch
from
sarroutbi:202404301829-pkcs11-tool-uris
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarroutbi
force-pushed
the
202404301829-pkcs11-tool-uris
branch
9 times, most recently
from
May 6, 2024 10:00
542dbb0
to
7d554ea
Compare
sarroutbi
changed the title
WIP: Include URIs for PKCS#11 objects
Include URIs for PKCS#11 objects
May 6, 2024
Jakuje
reviewed
May 10, 2024
sarroutbi
force-pushed
the
202404301829-pkcs11-tool-uris
branch
3 times, most recently
from
May 13, 2024 10:48
454bf9e
to
2be0f27
Compare
Jakuje
reviewed
May 13, 2024
sarroutbi
force-pushed
the
202404301829-pkcs11-tool-uris
branch
10 times, most recently
from
May 13, 2024 14:04
1e5daa4
to
c9621a2
Compare
Jakuje
reviewed
May 13, 2024
sarroutbi
force-pushed
the
202404301829-pkcs11-tool-uris
branch
from
May 13, 2024 17:08
c9621a2
to
bffc9fb
Compare
Fixes: OpenSC#3129 Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>
sarroutbi
force-pushed
the
202404301829-pkcs11-tool-uris
branch
from
May 13, 2024 17:11
bffc9fb
to
5289269
Compare
Jakuje
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thank you for the patience and your contribution!
Thanks for your help on getting this to be approved. Happy to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3129
Tested with card: