Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "IASECC/Gemalto: add support" #2522

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Revert "IASECC/Gemalto: add support" #2522

wants to merge 1 commit into from

Conversation

frankmorgner
Copy link
Member

This reverts commit e93bd39.

It broke support for Gemalto MultiApp IAS/ECC v1.0.1, which can't select
files anymore. Propably we need a better way to distinguesh this card
from CARTE IAS ECC DUAL ID ONE COSMO.

@vjardin , do you maybe have an idea how to distinguish both cards so that they are both supported? I'm not an expert on IAS/ECC... all I know is that my card doesn't work anymore with the reverted commit.

Checklist
  • PKCS#11 module is tested
  • Windows minidriver is tested
  • macOS tokend is tested

This reverts commit e93bd39.

It broke support for Gemalto MultiApp IAS/ECC v1.0.1, which can't select
files anymore. Propably we need a better way to distinguesh this card
from CARTE IAS ECC DUAL ID ONE COSMO.
@vjardin
Copy link
Contributor

vjardin commented Mar 12, 2022

Hi @frankmorgner ,

I am puzzle since I do not have good ideas yet in order to distinguish both cards.
It was easy for me to buy the Cosmo one (per my commit log). Where can I buy/get a "Gemalto MultiApp IAS/ECC v1.0.1" ?

@frankmorgner
Copy link
Member Author

I'm not quite sure how to distinguish the two cards. I got mine from @viktorTarasov a couple of years ago as sample card. Attached, you'll find a log of runnint pkcs11-tool --test --login with my card. Maybe you can spot some bits that could be used...
iasecc_gemalto.txt

@vjardin
Copy link
Contributor

vjardin commented Mar 17, 2022

Thanks @frankmorgner

your iasecc_gemalto.txt : please, can you provide the logs of the same code (same version of opensc) when it works and does not work (so with and without your patch), the logs should be without the timestamps P:46835; T:0x140114622256960 12:40:09.011 ?

I'd like to do a diff of both traces.

Meanwhile, I'd be very interested to get such card too. I could not find it. Please, how did @viktorTarasov get it ? @viktorTarasov , can you help me to get one ?

@frankmorgner
Copy link
Member Author

iasecc_gemalto_bad.txt
Here you have a failing log.

@frankmorgner
Copy link
Member Author

In vim, I've removed the process/thread IDs via :%s/.*\[opensc-pkcs11\] //g:
iasecc_gemalto_bad_clean.txt
iasecc_gemalto_clean.txt

@frankmorgner
Copy link
Member Author

@vjardin any ideas?

@dengert
Copy link
Member

dengert commented Apr 19, 2022

Doing a diff of the two logs above, I am surprised at how many lines differ.
The revert only changes 1 file. yest there are line numbers that differ in many other files.
For example, ctx.c has some changes to the line numbers:

-ctx.c:858:sc_context_create: ===================================
-ctx.c:859:sc_context_create: opensc version: 0.22.0
+ctx.c:854:sc_context_create: ===================================
+ctx.c:855:sc_context_create: opensc version: 0.22.0

Can you checkout master build and run the test, then apply the revert PR to the same master and build and test again?

I suspect that you developed the PR against an older version of master with your PR and it fixed you problem. But your problem may have already been fixed in the github version of master via changes in other files.

@Jakuje
Copy link
Member

Jakuje commented Aug 10, 2022

Was there any progress on this issue?

@frankmorgner
Copy link
Member Author

@vjardin has a card that requires the changes currently in master while I have an older sample card from @viktorTarasov , which requires the change in question to be reverted. The problem is that we can't distinguish the two cards so I'm unsure how to proceed. It would be nice to keep my sample card functioning for future release tests. Maybe Viktor has some idea on how to continue.

@frankmorgner
Copy link
Member Author

@vjardin could you please generate a log as i did above with your card for comparison?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants