Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include URIs for PKCS#11 objects #3130

Merged
merged 1 commit into from May 21, 2024
Merged

Include URIs for PKCS#11 objects #3130

merged 1 commit into from May 21, 2024

Conversation

sarroutbi
Copy link
Contributor

Fixes: #3129

Tested with card:

$ opensc-tool -n
Using reader with a card: Yubico YubiKey OTP+CCID 00 00
Personal Identity Verification Card

@sarroutbi sarroutbi force-pushed the 202404301829-pkcs11-tool-uris branch 9 times, most recently from 542dbb0 to 7d554ea Compare May 6, 2024 10:00
@sarroutbi sarroutbi changed the title WIP: Include URIs for PKCS#11 objects Include URIs for PKCS#11 objects May 6, 2024
@sarroutbi sarroutbi marked this pull request as ready for review May 6, 2024 10:00
Jakuje
Jakuje reviewed May 10, 2024
View reviewed changes
src/tools/pkcs11-tool.c Outdated Show resolved Hide resolved
src/tools/pkcs11-tool.c Outdated Show resolved Hide resolved
src/tools/pkcs11-tool.c Outdated Show resolved Hide resolved
@sarroutbi sarroutbi force-pushed the 202404301829-pkcs11-tool-uris branch 3 times, most recently from 454bf9e to 2be0f27 Compare May 13, 2024 10:48
Jakuje
Jakuje reviewed May 13, 2024
View reviewed changes
src/tools/pkcs11-tool.c Outdated Show resolved Hide resolved
@sarroutbi sarroutbi force-pushed the 202404301829-pkcs11-tool-uris branch 10 times, most recently from 1e5daa4 to c9621a2 Compare May 13, 2024 14:04
@sarroutbi sarroutbi requested a review from Jakuje May 13, 2024 14:25
Jakuje
Jakuje reviewed May 13, 2024
View reviewed changes
src/tools/pkcs11-tool.c Outdated Show resolved Hide resolved
@sarroutbi sarroutbi force-pushed the 202404301829-pkcs11-tool-uris branch from c9621a2 to bffc9fb Compare May 13, 2024 17:08
@sarroutbi
Include URIs for PKCS#11 objects
5289269 
Fixes: OpenSC#3129

Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>
@sarroutbi sarroutbi force-pushed the 202404301829-pkcs11-tool-uris branch from bffc9fb to 5289269 Compare May 13, 2024 17:11
@sarroutbi sarroutbi requested a review from Jakuje May 13, 2024 17:25
Jakuje
Jakuje approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thank you for the patience and your contribution!

@sarroutbi
Copy link
Contributor Author

sarroutbi commented May 14, 2024 •
edited

lgtm. Thank you for the patience and your contribution!

Thanks for your help on getting this to be approved. Happy to help.

@Jakuje
Copy link
Member

Jakuje commented May 21, 2024

Thank you!

@Jakuje Jakuje merged commit b90191e into OpenSC:master May 21, 2024
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jakuje Jakuje Jakuje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pkcs11-tool: extend for printing the PKCS#11 URI for the objects
2 participants
@sarroutbi @Jakuje