Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not keep map packages loaded on Game start to reduce memory impact #21408

Merged
merged 1 commit into from Apr 30, 2024

Conversation

cclecle
Copy link

@cclecle cclecle commented Apr 24, 2024

Address the following issue:
#21407

OpenRA.Game/Map/MapCache.cs Outdated Show resolved Hide resolved
OpenRA.Game/Map/MapCache.cs Outdated Show resolved Hide resolved
OpenRA.Game/Map/MapCache.cs Outdated Show resolved Hide resolved
OpenRA.Game/Map/MapPreview.cs Show resolved Hide resolved
OpenRA.Game/Map/MapPreview.cs Outdated Show resolved Hide resolved
OpenRA.Game/Map/MapPreview.cs Outdated Show resolved Hide resolved
OpenRA.Game/Map/MapPreview.cs Show resolved Hide resolved
OpenRA.Game/Map/MapCache.cs Outdated Show resolved Hide resolved
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PunkPun PunkPun merged commit e5a7b6e into OpenRA:bleed Apr 30, 2024
3 checks passed
@PunkPun
Copy link
Member

PunkPun commented Apr 30, 2024

changelog

@PunkPun
Copy link
Member

PunkPun commented Apr 30, 2024

I think it would make sense to add package disposal on game end as to not be bloating the ram over time. Or on server start we could dispose of all but the selected map's package

@cclecle
Copy link
Author

cclecle commented Apr 30, 2024

thanks for the merge :)
I will have a look for the last comment.

@Mailaender Mailaender changed the title Do not keep map pakages loaded on Game start to reduce memory impact Do not keep map packages loaded on Game start to reduce memory impact May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants