Don't allocate empty sheets #21370
Open
Don't allocate empty sheets #21370
+29
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoosterDragon
approved these changes
Mar 13, 2024
| if (Current == null) | ||
| { | ||
| Current = allocateSheet(); | ||
| Current.CreateBuffer(); |
There was a problem hiding this comment.
We can get away without the CreateBuffer call here and below, they'll be created when Util.FastCopyIntoChannel accesses the sheet data anyway.
There was a problem hiding this comment.
I'm not sure we can. I feel like we need a bit more unified handling of empty sprites
anvilvapre
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently sheet builder allocates empty BGRA sheets for RA, TD and TS