Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D2k husk improvements #21307

Merged
merged 1 commit into from
May 4, 2024
Merged

Conversation

Porenutak
Copy link
Contributor

PR adds missing husk Sprites for Sonic tank, Missile tank, Deviator
Adds minor visual improvements:

  • change husk color overlay (so its not just black smudge)
  • adds variations to husk VFX via condition
  • adds shrapnels into tanks explosion

Enable capturing husk with engineer and adjust husk HP based on Enhanced balance.
This feature is currently broken because of #21304
d2k-2024-01-18T095514026Z
d2k-2024-01-18T095505243Z
d2k-2024-01-18T095455313Z

mods/d2k/bits/deviatorhusk/deviatorhusk-0004.png Outdated Show resolved Hide resolved
mods/d2k/rules/infantry.yaml Outdated Show resolved Hide resolved
mods/d2k/rules/infantry.yaml Outdated Show resolved Hide resolved
mods/d2k/rules/husks.yaml Outdated Show resolved Hide resolved
mods/d2k/rules/vehicles.yaml Show resolved Hide resolved
@Porenutak Porenutak force-pushed the D2k-husk-improvements branch 2 times, most recently from 17d3d96 to 10f1e9a Compare January 22, 2024 08:46
@Porenutak
Copy link
Contributor Author

Fixed

abcdefg30
abcdefg30 previously approved these changes Jan 29, 2024
Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested but changes lgtm.

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure we want to add so much custom art into the game?

It also seems that most husks now live for way shorter of a period, they explode almost as soon as they are created. And of the husks that stay around longer and have the smoke decoration, the decoration times out faster that the husk dies

@Porenutak
Copy link
Contributor Author

RA also adds missing husk in its own custom sprites.

It also seems that most husks now live for way shorter of a period

Husk now live much long that before. Otherwise its a mistake. Will re-check. Husk capturing and live time are taken from Enhance maps. They live long enough for players to build engi and capture near by husks.

@Porenutak
Copy link
Contributor Author

It also seems that most husks now live for way shorter of a period, they explode almost as soon as they are created. And on he husks that stay around longer and have the smoke decoration, the decoration times out faster that the husk dies

I recheck husk live period and its working as intentent. Husk live may be shorter if lots unit attack on vehicle at same time. So damage does also to the husk because of projectile delay.
I increased husk Smoke FX duration from 500 to 1500.

@PunkPun
Copy link
Member

PunkPun commented Jan 31, 2024

huh, I'm not sure what was wrong with my testing. I had recorded this video

video.mp4

husks seem to live for a proper duration now though

@PunkPun
Copy link
Member

PunkPun commented Feb 5, 2024

something that was not mentioned is harvesters exploding when they have spice, instead of leaving a husk

Harv.mp4

@Porenutak
Copy link
Contributor Author

Porenutak commented Feb 5, 2024

sorry, I forgot mention that.
Main reason for this is balance. Killing harvester cost you lot of effort. (and lots of assets in the process). Its the stronges unit in the game. This way enemy cant retake they harvester husk he lots one.

@Porenutak
Copy link
Contributor Author

I notice that I put unused file here by accident. Fixed.

@Dzierzan
Copy link

Dzierzan commented Mar 3, 2024

huh, I'm not sure what was wrong with my testing. I had recorded this video

video.mp4
husks seem to live for a proper duration now though

Missile tank husk has wrong offset. It moves a bit when husk is created.

@Porenutak
Copy link
Contributor Author

Missile tank husk has wrong offset. It moves a bit when husk is created.

Fixed
Some angles will still be little off because husk use just 16 angles, but vehicle 32

- adjust husk color overlay
- engineer can capture husk
- balance changes to husk HP
@Mailaender Mailaender merged commit fa0254c into OpenRA:bleed May 4, 2024
3 checks passed
@Mailaender
Copy link
Member

Changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants